-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golang part of plugin incorrect handle empty (rows=0) results from Clickhouse #335
Comments
@bmanth60 JFYI |
## Breaking changes * On latest Grafana 7.x releases, template variables SQL queries shall return only scalar types of values, see Altinity/clickhouse-grafana#328 ## Enhancement: * add support Apple M1 ;) * switch to new grafana plugin Golang SDK, thanks to @bmanth60 and @valeriakononenko for help * add BasicAuth support for alerts, see Altinity/clickhouse-grafana#267 ## Fixes: * fix github actions backend build * fix UNION ALL parsing, see Altinity/clickhouse-grafana#319 * fix many issues with alerting * Altinity/clickhouse-grafana#305 * Altinity/clickhouse-grafana#327 * Altinity/clickhouse-grafana#334 * Altinity/clickhouse-grafana#335 Signed-off-by: Eugene Klimov <[email protected]>
@Slach I read the PR, but I don't quite understand the fix, is it that there is a nullable and low cardinality type? |
the main goal of fix each
also, SQL queries can return nullable values and DateTime64, so I add support for this corner cases LowCardinality also supported for properly parsing label values Also, if we return SQL result without a timestamp field |
Interesting, thanks! |
## Breaking changes * On latest Grafana 7.x releases, template variables SQL queries shall return only scalar types of values, see Altinity/clickhouse-grafana#328 ## Enhancement: * add support Apple M1 ;) * switch to new grafana plugin Golang SDK, thanks to @bmanth60 and @valeriakononenko for help * add BasicAuth support for alerts, see Altinity/clickhouse-grafana#267 ## Fixes: * fix github actions backend build * fix UNION ALL parsing, see Altinity/clickhouse-grafana#319 * fix many issues with alerting * Altinity/clickhouse-grafana#305 * Altinity/clickhouse-grafana#327 * Altinity/clickhouse-grafana#334 * Altinity/clickhouse-grafana#335 Signed-off-by: Eugene Klimov <[email protected]>
## Breaking changes * On latest Grafana 7.x releases, template variables SQL queries shall return only scalar types of values, see Altinity/clickhouse-grafana#328 ## Enhancement: * add support Apple M1 ;) * switch to new grafana plugin Golang SDK, thanks to @bmanth60 and @valeriakononenko for help * add BasicAuth support for alerts, see Altinity/clickhouse-grafana#267 ## Fixes: * fix github actions backend build * fix UNION ALL parsing, see Altinity/clickhouse-grafana#319 * fix many issues with alerting * Altinity/clickhouse-grafana#305 * Altinity/clickhouse-grafana#327 * Altinity/clickhouse-grafana#334 * Altinity/clickhouse-grafana#335 Signed-off-by: Eugene Klimov <[email protected]>
need to research howto return "NODATA" instead of "ERROR" when we got empty result from ClickHouse
The text was updated successfully, but these errors were encountered: