-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with alerts with multiple lines (group by) #230
Comments
@oleg-savko, thanks for reporting, do you use time Series format or table Format for your query? |
I use Time Series format. |
as a quick workaround
I going fix your issue tomorrow |
@Slach Great! Thank you very much!) |
Merged
Slach
added a commit
that referenced
this issue
Jul 24, 2020
# 2.0.3 (2020-07-24) ## Enhancements: * add setup notes for Grafana 7.x to README * add SQL preprocessing logic on browser side with <% js code subset %>, #186, thanks @fgbogdan * improve alerts query processing for use case when `query(query_name, from, to)` time range is less than visible dashboard time range, see #237 * improve alerts json parsing in golang part for case when we have string fields in response which interprets as series name, see #230 * properly parsing POST queries in golang part of plugin, #228, thanks @it1804 ## Fixes: * add Vagrantfile for statefull environment and allow to upgrade scenario like grafana 7.1.0 + grafana-cli upgrade-all * fix #244 * fix #243 * add multiple dashboard examples for github issues: * fix #240 * fix #135 * fix #245 * fix #238 * fix #232 * fix #127 * fix #141
Slach
added a commit
to Altinity/grafana-plugin-repository
that referenced
this issue
Jul 24, 2020
## Enhancements: * add setup notes for Grafana 7.x to README * add SQL preprocessing logic on browser side with <% js code subset %>, Altinity/clickhouse-grafana#186, thanks @fgbogdan * improve alerts query processing for use case when `query(query_name, from, to)` time range is less than visible dashboard time range, see Altinity/clickhouse-grafana#237 * improve alerts json parsing in golang part for case when we have string fields in response which interprets as series name, see Altinity/clickhouse-grafana#230 * properly parsing POST queries in golang part of plugin, Altinity/clickhouse-grafana#228, thanks @it1804 ## Fixes: * add Vagrantfile for statefull environment and allow to upgrade scenario like grafana 7.1.0 + grafana-cli upgrade-all * fix Altinity/clickhouse-grafana#244 * fix Altinity/clickhouse-grafana#243 * add multiple dashboard examples for github issues: * fix Altinity/clickhouse-grafana#240 * fix Altinity/clickhouse-grafana#135 * fix Altinity/clickhouse-grafana#245 * fix Altinity/clickhouse-grafana#238 * fix Altinity/clickhouse-grafana#232 * fix Altinity/clickhouse-grafana#127 * fix Altinity/clickhouse-grafana#141 Signed-off-by: Eugene Klimov <[email protected]>
Slach
added a commit
to Altinity/grafana-plugin-repository
that referenced
this issue
Aug 13, 2020
# 2.1.0 (2020-08-13) ## Enhancement: * add "Skip comments" checkbox to query editor to pass SQL comments to server, fix Altinity/clickhouse-grafana#265 * add setup notes for Grafana 7.x to README * add SQL preprocessing logic on browser side with <% js code subset %>, Altinity/clickhouse-grafana#186, thanks @fgbogdan * improve alerts query processing for use case when `query(query_name, from, to)` time range is less than visible dashboard time range, see Altinity/clickhouse-grafana#237 * improve alerts json parsing in golang part for case when we have string fields in response which interprets as series name, see Altinity/clickhouse-grafana#230 * properly parsing POST queries in golang part of plugin, Altinity/clickhouse-grafana#228, thanks @it1804 ## Fixes: * fix corner cases for $macro + subquery, see Altinity/clickhouse-grafana#276 and Altinity/clickhouse-grafana#277 * fix parallel query execution, see Altinity/clickhouse-grafana#273 * fix identifiers quotes, see Altinity/clickhouse-grafana#276, Altinity/clickhouse-grafana#277 * fix plugin.json for pass `grafana-plugin-repository` plugin validator * fix multi-value variables behavior - Altinity/clickhouse-grafana#252 * add Vagrantfile for statefull environment and allow to upgrade scenario like grafana 7.1.0 + grafana-cli upgrade-all * fix Altinity/clickhouse-grafana#244 * fix Altinity/clickhouse-grafana#243 * add multiple dashboard examples for github issues: * fix Altinity/clickhouse-grafana#240 * fix Altinity/clickhouse-grafana#135 * fix Altinity/clickhouse-grafana#245 * fix Altinity/clickhouse-grafana#238 * fix Altinity/clickhouse-grafana#232 * fix Altinity/clickhouse-grafana#127 * fix Altinity/clickhouse-grafana#141 Signed-off-by: Eugene Klimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I try to add alerts for graph with multiple lines with group by, its seems like try to parse all columns to float and throw exception when parse label:
Example query:
Throw exception:
"tsdb.HandleRequest() error rpc error: code = Unknown desc = unable to parse value /client-area/registration/route/UPLOAD for 'h': strconv.ParseFloat: parsing "/client-area/registration/route/UPLOAD": invalid syntax"
Expected behavior: check alert for every line individually and not try to parse labels to float
The text was updated successfully, but these errors were encountered: