feat: wallet password wizard #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszantas
commented
May 9, 2022
tarnas14
reviewed
May 10, 2022
| @@ -0,0 +1,4 @@ | |||
| export interface WalletPasswordWizardProps { | |||
| submitBtnText?: string | |||
| onSuccess?: () => void | |||
There was a problem hiding this comment.
I can understand why the above is optional, you could have a default 'submit' text, but onSuccess looks like a required prop to me
There was a problem hiding this comment.
Not necessary in the Wizard, because on form submission, the container dispatches the action and changes the Redux state. So the parent component not necessary need to know whether form submit was successful, it can just observe the Redux state with some selector.
tarnas14
reviewed
May 10, 2022
| @@ -10,6 +10,7 @@ export const unlockWallet = createAsyncThunk< | |||
| }, | |||
| WalletPassword | |||
| >('wallet/unlock', async password => { | |||
| console.log('thunk') | |||
tarnas14
approved these changes
May 10, 2022
corquaid
reviewed
May 10, 2022
| @@ -10,6 +10,7 @@ export const unlockWallet = createAsyncThunk< | |||
| }, | |||
| WalletPassword | |||
| >('wallet/unlock', async password => { | |||
| console.log('thunk') | |||
CjS77
pushed a commit
that referenced
this pull request
May 12, 2022
* Add Icons and statuses to MiningBox, initialize WalletPasswordWizard * Password Wizard
CjS77
pushed a commit
that referenced
this pull request
May 13, 2022
* Add Icons and statuses to MiningBox, initialize WalletPasswordWizard * Password Wizard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
react-hook-formpackageInputcomponent by addingforwardRef, so it plays nice withreact-hook-formwarningvariantWalletPasswordWizardcontainer andWalletPasswordFormcomponent. TheWalletPasswordFormis pure HTML withreact-hook-form. TheWalletPasswordWizardrendersWalletPasswordFormand connects with Redux.WalletPasswordWizardto the Tari Mining to handle situation when the wallet is not configured yet.Motivation and Context
#12
Missing:
How Has This Been Tested?
Callout component
Wallet Password Wizard
Screen.Recording.2022-05-09.at.21.29.55.mov