Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "bobbleDown" animation for Entities. #1218

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

armlesshobo
Copy link
Contributor

No description provided.

2.) Delete implementation body of bobbleDown(Node)
3.) Make bobbleDown(Node) call this new bobbleDown(Animatable) by calling node.toAnimatable()
@armlesshobo armlesshobo changed the title Refactor bobbleDown changes Add "bobbleDown" animation for Entities. Dec 16, 2022
@armlesshobo
Copy link
Contributor Author

Gentle bump

Copy link
Owner

@AlmasB AlmasB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, many thanks.

@codecov-commenter
Copy link

Codecov Report

Merging #1218 (c609b8c) into dev (d5c546a) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #1218      +/-   ##
============================================
+ Coverage     58.58%   58.66%   +0.07%     
- Complexity     2961     2965       +4     
============================================
  Files           303      303              
  Lines         15002    15003       +1     
  Branches       1517     1517              
============================================
+ Hits           8789     8801      +12     
+ Misses         5707     5696      -11     
  Partials        506      506              
Impacted Files Coverage Δ
...tlin/com/almasb/fxgl/animation/AnimationBuilder.kt 88.60% <100.00%> (+0.04%) ⬆️
fxgl/src/main/kotlin/com/almasb/fxgl/app/Engine.kt 81.69% <0.00%> (+8.45%) ⬆️
.../src/main/kotlin/com/almasb/fxgl/app/LoopRunner.kt 94.54% <0.00%> (+9.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlmasB AlmasB merged commit aaba1de into AlmasB:dev Dec 30, 2022
@AlmasB
Copy link
Owner

AlmasB commented Dec 30, 2022

looks good, many thanks.

@armlesshobo armlesshobo deleted the animation-build branch January 1, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants