Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Chinese README file #1186

Merged
merged 7 commits into from
Jul 21, 2022
Merged

docs: Add Chinese README file #1186

merged 7 commits into from
Jul 21, 2022

Conversation

lhDream
Copy link
Contributor

@lhDream lhDream commented Jul 20, 2022

No description provided.

Copy link
Owner

@AlmasB AlmasB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @lhDream , this is a great idea!

@chengenzhao as you kindly offered to help with #1172, can you help me review README_CN please.

README.md Outdated Show resolved Hide resolved
@AlmasB AlmasB changed the title Add Chinese README file docs: Add Chinese README file Jul 20, 2022
README_CN.md Outdated

### 贡献与支持

如果您想从源代码构建 FXGL 或想贡献,请参阅[贡献指南](https://github.com/lhDream/FXGL/blob/dev/CONTRIBUTING.md)(包括非代码)。FXGL 是完全模块化的,因此新的贡献者不需要了解整个代码库,只需要了解做出贡献的模块即可。贡献将根据[行为准则](https://github.com/lhDream/FXGL/blob/dev/CODE_OF_CONDUCT.md)进行审查。
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these links (contributing and code of conduct) need to be rerouted to main repo.

Copy link
Contributor

@chengenzhao chengenzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根据一些语言习惯和上下文环境,做了相应的修改建议
Based on language custom and context, provided some suggestions

README.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated
如需快速深入了解代码,请参阅独立的[基本示例](https://github.com/AlmasB/FXGL/tree/dev/fxgl-samples/src/main/java/basics)。否则,请参阅:

- [展示预告片](https://youtu.be/fuDQg7W0v4g)
- [将 FXGL 与 IntelliJ 一起使用](https://youtu.be/LhmlFC6KE2Q)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ FXGL 与 IntelliJ 一起使用](https://youtu.be/LhmlFC6KE2Q)
- [ FXGL 与 IntelliJ 一起使用](https://youtu.be/LhmlFC6KE2Q)

README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
lhDream and others added 2 commits July 21, 2022 09:45
Links (contributions and code of conduct) rerouted to the main repository
@AlmasB
Copy link
Owner

AlmasB commented Jul 21, 2022

Thank you both.

@chengenzhao let me know if ok to merge.

@chengenzhao
Copy link
Contributor

@lhDream 还有两个修改建议,是遗漏了还是保留原先的翻译?

@lhDream
Copy link
Contributor Author

lhDream commented Jul 21, 2022

@chengenzhao 两个?那应该是漏了一个,等下我瞅一眼。在考虑用原来的还是换成这个 在IntelliJ中使用FXGL

Co-authored-by: Chengen Zhao <[email protected]>
@chengenzhao
Copy link
Contributor

我觉得:在IntelliJ中使用FXGL
这个翻译比较好,改好就行了,我先approve一下

@lhDream
Copy link
Contributor Author

lhDream commented Jul 21, 2022

OK

@chengenzhao
Copy link
Contributor

@AlmasB the doc is good to go

@AlmasB AlmasB merged commit f6a419b into AlmasB:dev Jul 21, 2022
@AlmasB
Copy link
Owner

AlmasB commented Jul 21, 2022

Great, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants