Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransformComponent update direction3D on rotation change #924

Closed
AlmasB opened this issue Dec 24, 2020 · 1 comment
Closed

TransformComponent update direction3D on rotation change #924

AlmasB opened this issue Dec 24, 2020 · 1 comment
Assignees
@AlmasB
Labels
type:bug Doesn't behave according to specification

Comments

@AlmasB
Copy link
Owner

AlmasB commented Dec 24, 2020 •
edited
Loading

When rotation Y or X change, we also need to update direction3D. Possibly, through a listener or just before the value of direction3D is queried. Otherwise it creates a bug that moves the component in the wrong direction.

It would be beneficial to have a direct setter for direction3D, perhaps direction3DProperty() too.
@AlmasB AlmasB added the type:bug Doesn't behave according to specification label Dec 24, 2020
@AlmasB AlmasB self-assigned this Dec 24, 2020
AlmasB added a commit that referenced this issue Jan 21, 2023
@AlmasB
fix: updating rotationX and rotationY now correctly updates direction3D
6a1bf56 
#924
@AlmasB AlmasB closed this as completed in b31db7b Jan 21, 2023
@Snoopy137
Copy link

Hi @AlmasB any chance this fix will be applied to java library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlmasB AlmasB

Labels
type:bug Doesn't behave according to specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlmasB @Snoopy137