feat: adds a Dockerfile for hortacloud deployment #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtyoung84
reviewed
Jan 12, 2024
hortacloud-deployment/Dockerfile
Outdated
|
|
||
| RUN git clone https://github.com/JaneliaSciComp/hortacloud/ | ||
| WORKDIR /hortacloud | ||
| ADD .env . |
There was a problem hiding this comment.
We don't want to add the .env file in the docker image. We will just copy it into the container once the container starts.
jtyoung84
reviewed
Jan 12, 2024
hortacloud-deployment/README.md
Outdated
| Refer to hortacloud [deployment instruction](https://hortacloud.janelia.org/docs/administration/aws/deployment/) for detailed steps | ||
| ### Container setup | ||
| - Create a **.env** file that contains all required environment variables. | ||
| - Run `docker build .` to build a docker image. |
There was a problem hiding this comment.
You can build it with a specific tag instead of looking for the image id after the fact.
jtyoung84
reviewed
Jan 12, 2024
hortacloud-deployment/Dockerfile
Outdated
|
|
||
| RUN npm install -g aws-cdk | ||
|
|
||
| RUN git clone https://github.com/JaneliaSciComp/hortacloud/ |
There was a problem hiding this comment.
I think David mentioned he'd prefer to have a single Docker environment that can be used to deploy each update rather than building a new image each time. You can add an extra script that runs when a container starts that pulls the .env from s3 and runs this git clone command. Or you can add those steps as instructions in the readme file.
jtyoung84
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12