Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autopep8 completely #67

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Remove autopep8 completely #67

merged 1 commit into from
Apr 3, 2024

Conversation

shrik450
Copy link
Collaborator

@shrik450 shrik450 commented Apr 3, 2024

This PR removes autopep8 and uses ruff instead for formatting checking in CI. We are already using ruff for linting, and it comes with a formatter, so we don't need to manage autopep8 for formatting. This change does lead to different formatting because ruff's is black-compatible.

Replaced with ruff for formatting
@shrik450 shrik450 requested a review from a team as a code owner April 3, 2024 15:02
@shrik450 shrik450 requested a review from McRaeAlex April 3, 2024 19:22
@shrik450
Copy link
Collaborator Author

shrik450 commented Apr 3, 2024

Are we sticking with 2 reviewers min here or is the sole AllSpiceIO/devs review enough to merge? I see a few PRs with both.

@jtran
Copy link
Contributor

jtran commented Apr 3, 2024

Branch protections on this repo only require 1. I think it's enough, but feel free to make suggestions if you'd like to see a change.

@shrik450 shrik450 merged commit e5fc57c into main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants