Add generate netlist routine #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kdumontnu
force-pushed
the
kd/pcb_netlist
branch
from
a51fc9c to
ac571a4
Compare
McRaeAlex
requested changes
Oct 25, 2023
McRaeAlex
approved these changes
Oct 26, 2023
jtran
reviewed
Oct 27, 2023
| time.sleep(0.5) | ||
| continue | ||
|
|
||
| return pcb_json["component_instances"] |
There was a problem hiding this comment.
If the retries are ever exhausted, this line will raise UnboundLocalError: local variable 'pcb_json' referenced before assignment.
There was a problem hiding this comment.
Good point - I'm working on improving error handling. I'll add that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #48 ✅
Depends on https://github.com/AllSpiceIO/crysknife/pull/691 ✅
Largely derived from the BOM generation, but I keep it a bit simpler here.