Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POST instead of PUT for merging Design Reviews #208

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

shrik450
Copy link
Collaborator

This bug wasn't caught because we didn't have a test before. I've added one to test this case.

@shrik450 shrik450 requested a review from a team as a code owner February 13, 2025 20:27
@shrik450 shrik450 force-pushed the su/dr-merge-method branch 2 times, most recently from d2286c8 to ffe44f2 Compare February 17, 2025 14:51
Copy link

github-actions bot commented Feb 17, 2025

Coverage Summary

Total Project Coverage

  • Line Coverage: 86.89% (2068/2380)
  • Branch Coverage: 71.57% (438/612)

Coverage by File

File Line Coverage Branch Coverage Lines (Covered/Total) Branches (Covered/Total)
allspice/__init__.py 100.00% 100.00% 5/5 0/0
allspice/allspice.py 81.78% 68.42% 175/214 52/76
allspice/apiobject.py 83.47% 46.53% 1050/1258 94/202
allspice/baseapiobject.py 85.29% 75.00% 87/102 24/32
allspice/exceptions.py 100.00% 100.00% 14/14 0/0
allspice/ratelimiter.py 100.00% 100.00% 22/22 4/4
allspice/utils/__init__.py 100.00% 100.00% 0/0 0/0
allspice/utils/bom_generation.py 100.00% 100.00% 112/112 40/40
allspice/utils/core.py 94.12% 50.00% 16/17 1/2
allspice/utils/list_components.py 92.27% 87.30% 537/582 213/244
allspice/utils/netlist_generation.py 92.59% 83.33% 50/54 10/12

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • allspice/apiobject.py (100%)

Summary

  • Total: 5 lines
  • Missing: 0 lines
  • Coverage: 100%

This bug wasn't caught because we didn't have a test before. I've added
one to test this case.
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@shrik450 shrik450 merged commit f5a486d into main Feb 17, 2025
4 checks passed
@shrik450 shrik450 deleted the su/dr-merge-method branch February 17, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants