Enforce max retries in list_components #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, we would retry forever if the JSON wasn't generated. This usually wasn't a problem because the JSON would eventually be generated *or* lead to a server error, but we've seen cases where this hasn't been true. Either way, we should've limited the number of retries, `list_components` just didn't count the number of attempts. This commit counts the attempts, stops at 5 retires, and tests this behavior.
kdumontnu
approved these changes
Dec 2, 2024
The default sleep time between retries is too short for orcad/system capture files. This commit increases the sleep time to 1 second, giving a total of roughly 4 seconds to time out. Ideally we'd make this a configurable parameter, but that requires a lot more work and would also involve generate-bom.
Coverage SummaryTotal Project Coverage
Coverage by File
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changes
Summary
|
McRaeAlex
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, we would retry forever if the JSON wasn't generated. This usually wasn't a problem because the JSON would eventually be generated or lead to a server error, but we've seen cases where this hasn't been true. Either way, we should've limited the number of retries,
list_componentsjust didn't count the number of attempts. This commit counts the attempts, stops at 5 retires, and tests this behavior.