Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system capture test snapshots with added component attributes #187

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

shrik450
Copy link
Collaborator

The latest version of AllSpice Hub bundles more component attributes for system capture projects, which led to our tests failing in the scheduled runs which do not use the cassettes. This commit updates the cassettes and snapshots to include this data.

@shrik450 shrik450 requested a review from a team as a code owner October 14, 2024 12:48
Copy link

github-actions bot commented Oct 14, 2024

Coverage Summary

Total Project Coverage

  • Line Coverage: 86.90% (2043/2351)
  • Branch Coverage: 71.76% (432/602)

Coverage by File

File Line Coverage Branch Coverage Lines (Covered/Total) Branches (Covered/Total)
allspice/__init__.py 100.00% 100.00% 5/5 0/0
allspice/allspice.py 81.43% 68.42% 171/210 52/76
allspice/apiobject.py 83.58% 46.35% 1033/1236 89/192
allspice/baseapiobject.py 85.29% 75.00% 87/102 24/32
allspice/exceptions.py 100.00% 100.00% 14/14 0/0
allspice/ratelimiter.py 100.00% 100.00% 22/22 4/4
allspice/utils/__init__.py 100.00% 100.00% 0/0 0/0
allspice/utils/bom_generation.py 100.00% 100.00% 112/112 40/40
allspice/utils/core.py 94.12% 50.00% 16/17 1/2
allspice/utils/list_components.py 92.06% 86.89% 533/579 212/244
allspice/utils/netlist_generation.py 92.59% 83.33% 50/54 10/12

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you think it's worth updating the tests to include any of these attributes?

@shrik450
Copy link
Collaborator Author

shrik450 commented Oct 14, 2024

The BOM tests do include one attribute that's now populated (you can see the component column in the CSVs). However, the list_components test that all attributes are present, so we don't need to specify any more! E.g. this change: https://github.com/AllSpiceIO/py-allspice/pull/187/files#diff-2a183d7c52fa65b9a1a8a8f2714f16bbfaaf134639c58c23a77685ce9239d2cdR3-R17

The latest version of AllSpice Hub bundles more component attributes for
system capture projects, which led to our tests failing in the scheduled
runs which do not use the cassettes. This commit updates the cassettes
and snapshots to include this data.
@shrik450 shrik450 force-pushed the su/syscap-added-components branch from c7d9024 to 9af4d46 Compare October 16, 2024 14:18
@shrik450 shrik450 merged commit 716bda4 into main Oct 17, 2024
4 checks passed
@shrik450 shrik450 deleted the su/syscap-added-components branch October 17, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants