Add method to download an attachment #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Paging @hercastspice 🫡 |
Coverage SummaryTotal Project Coverage
Coverage by File
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changes
Summary
|
The browser_download_url property of attachments can be confusing, as it is a full URL and `allspice.requests_get_raw` doesn't work with absolute URLs. The new `Attachment.download_to_file` method provides a "blessed" way to download the attachment.
shrik450
force-pushed
the
su/downlod-attachment
branch
from
9d574d9 to
28c72a6
Compare
|
Thanks a lot! |
kdumontnu
approved these changes
Sep 16, 2024
We've got the test added here, but in py-allspice terms that's an API test so if that's not what you meant I can add something else. |
McRaeAlex
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser_download_url property of attachments can be confusing, as it is a full URL and
allspice.requests_get_rawdoesn't work with absolute URLs. The newAttachment.download_to_filemethod provides a "blessed" way to download the attachment.