Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pin information in components #180

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Include pin information in components #180

merged 2 commits into from
Sep 19, 2024

Conversation

shrik450
Copy link
Collaborator

Adds a _pins key in the output of list_components which includes data from all the pins in the component.

This is very stopgap to unblock work on multiboard wireviz, and we should make a decision long-term on how we want to make the component data accessible.

Adds a `_pins` key in the output of `list_components` which includes
data from all the pins in the component.
@shrik450 shrik450 requested a review from a team as a code owner September 10, 2024 16:43
Copy link

github-actions bot commented Sep 10, 2024

Coverage Summary

Total Project Coverage

  • Line Coverage: 86.05% (1789/2079)
  • Branch Coverage: 73.38% (452/616)

Coverage by File

File Line Coverage Branch Coverage Lines (Covered/Total) Branches (Covered/Total)
allspice/__init__.py 100.00% 100.00% 5/5 0/0
allspice/allspice.py 81.43% 69.23% 171/210 54/78
allspice/apiobject.py 83.67% 60.66% 1030/1231 165/272
allspice/baseapiobject.py 87.25% 84.62% 89/102 44/52
allspice/exceptions.py 100.00% 100.00% 14/14 0/0
allspice/ratelimiter.py 100.00% 100.00% 22/22 4/4
allspice/utils/__init__.py 100.00% 100.00% 0/0 0/0
allspice/utils/bom_generation.py 99.11% 98.00% 111/112 49/50
allspice/utils/core.py 94.12% 50.00% 16/17 1/2
allspice/utils/list_components.py 90.06% 85.00% 281/312 119/140
allspice/utils/netlist_generation.py 92.59% 88.89% 50/54 16/18

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • allspice/utils/list_components.py (100%)

Summary

  • Total: 19 lines
  • Missing: 0 lines
  • Coverage: 100%

Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shrik450 shrik450 merged commit c56de4c into main Sep 19, 2024
4 checks passed
@shrik450 shrik450 deleted the su/pins-in-components branch September 19, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants