Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to fetch git trees #175

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add endpoint to fetch git trees #175

merged 1 commit into from
Aug 22, 2024

Conversation

shrik450
Copy link
Collaborator

Closes ID-491. Already in use for where-used.

@shrik450 shrik450 requested a review from a team as a code owner August 21, 2024 19:31
Copy link

Copy link

Coverage Summary

Total Project Coverage

  • Line Coverage: 85.69% (1791/2090)
  • Branch Coverage: 72.15% (456/632)

Coverage by File

File Line Coverage Branch Coverage Lines (Covered/Total) Branches (Covered/Total)
allspice/__init__.py 100.00% 100.00% 5/5 0/0
allspice/allspice.py 81.43% 69.23% 171/210 54/78
allspice/apiobject.py 83.67% 60.66% 1030/1231 165/272
allspice/baseapiobject.py 87.25% 84.62% 89/102 44/52
allspice/exceptions.py 100.00% 100.00% 14/14 0/0
allspice/ratelimiter.py 100.00% 100.00% 22/22 4/4
allspice/utils/__init__.py 100.00% 100.00% 0/0 0/0
allspice/utils/bom_generation.py 95.07% 84.21% 135/142 64/76
allspice/utils/core.py 94.12% 50.00% 16/17 1/2
allspice/utils/list_components.py 88.40% 83.08% 259/293 108/130
allspice/utils/netlist_generation.py 92.59% 88.89% 50/54 16/18

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • allspice/allspice.py (100%)
  • allspice/apiobject.py (81.8%): Missing lines 464-466,469

Summary

  • Total: 27 lines
  • Missing: 4 lines
  • Coverage: 85%
Diff Coverage Details

allspice/apiobject.py

Lines 460-473

  460     def __init__(self, allspice_client):
  461         super().__init__(allspice_client)
  462 
  463     def __eq__(self, other) -> bool:
! 464         if not isinstance(other, GitEntry):
! 465             return False
! 466         return self.sha == other.sha
  467 
  468     def __hash__(self) -> int:
! 469         return hash(self.sha)
  470 
  471 
  472 class Repository(ApiObject):
  473     allow_manual_merge: Any

Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@shrik450 shrik450 merged commit 605bb0a into main Aug 22, 2024
4 checks passed
@shrik450 shrik450 deleted the su/tree-api branch August 22, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants