Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine multi-part components for OrCAD #161

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Combine multi-part components for OrCAD #161

merged 2 commits into from
Jul 16, 2024

Conversation

shrik450
Copy link
Collaborator

@shrik450 shrik450 commented Jul 9, 2024

Closes #155. Follow up to #147, combines OrCAD multi-part components using the newly added reference and logical_reference fields of components. The CSVs are a good way to see the diffs.

@shrik450 shrik450 requested review from kdumontnu and McRaeAlex July 9, 2024 19:55
@shrik450 shrik450 requested a review from a team as a code owner July 9, 2024 19:55
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on allspice update.

Copy link

Coverage Summary

Total Project Coverage

  • Line Coverage: 84.88% (1662/1958)
  • Branch Coverage: 70.79% (412/582)

Coverage by File

File Line Coverage Branch Coverage Lines (Covered/Total) Branches (Covered/Total)
allspice/__init__.py 100.00% 100.00% 5/5 0/0
allspice/allspice.py 80.98% 67.57% 166/205 50/74
allspice/apiobject.py 83.65% 60.90% 1003/1199 162/266
allspice/baseapiobject.py 86.02% 84.00% 80/93 42/50
allspice/exceptions.py 100.00% 100.00% 14/14 0/0
allspice/ratelimiter.py 100.00% 100.00% 22/22 4/4
allspice/utils/__init__.py 100.00% 100.00% 0/0 0/0
allspice/utils/bom_generation.py 92.21% 81.25% 71/77 39/48
allspice/utils/core.py 94.12% 50.00% 16/17 1/2
allspice/utils/list_components.py 86.18% 81.15% 237/275 99/122
allspice/utils/netlist_generation.py 94.12% 93.75% 48/51 15/16

Diff Coverage

Diff: origin/main...HEAD, staged and unstaged changes

  • allspice/utils/bom_generation.py (100%)
  • allspice/utils/list_components.py (100%)

Summary

  • Total: 21 lines
  • Missing: 0 lines
  • Coverage: 100%

@shrik450 shrik450 merged commit f6a810f into main Jul 16, 2024
4 checks passed
@shrik450 shrik450 deleted the su/orcad-multi branch July 16, 2024 19:20
@shrik450
Copy link
Collaborator Author

Depends on allspice update.

Yes - I'll hold off on tagging a release until that is deployed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi part components in OrCAD
4 participants