Eliminate N+1 API requests in issues #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #70. This issue was caused by `Issue` fetching the repository every time it is initialized via `parse_response`. This leads to an N+1 query, which can be especially cumbersome when fetching all issues of a repository with many issues. This commit fixes that by propagating the repository from the caller of `Issue.parse_response`, and eager loading it only in cases where one issue at a time is loaded.
kdumontnu
approved these changes
Jun 6, 2024
|
Yep, there's many tests which call |
jtran
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70.
This issue was caused by
Issuefetching the repository every time it is initialized viaparse_response. This leads to an N+1 query, which can be especially cumbersome when fetching all issues of a repository with many issues. This commit fixes that by propagating the repository from the caller ofIssue.parse_response, and eager loading it only in cases where one issue at a time is loaded.