Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract components list function for Altium from BOM #122

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

shrik450
Copy link
Collaborator

Closes #118.

Extracts a list_components_for_altium function from the BOM generation utility, and uses it for BOM generation as well. This is easier to do now as there are more changes incoming for components listing such as combining multi-symbol components.

Stacked on top of #119 as that should get merged before this.

@shrik450 shrik450 requested review from jtran and kdumontnu May 28, 2024 22:38
@shrik450 shrik450 self-assigned this May 28, 2024
@shrik450 shrik450 requested a review from a team as a code owner May 28, 2024 22:38
@shrik450

This comment was marked as outdated.

Base automatically changed from su/altium-kind to main May 29, 2024 21:39
@shrik450 shrik450 force-pushed the su/altium-refactor branch from 97083f7 to e8bc5ab Compare May 29, 2024 21:58
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 sorry, didn’t realize this was blocking the chain of PRs

@shrik450 shrik450 merged commit ee9c323 into main Jun 1, 2024
4 checks passed
@shrik450 shrik450 deleted the su/altium-refactor branch June 1, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Altium BOM generation to use list_components
3 participants