Fix issue with emphasis and whitespace #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
force-pushed
the
emphasis-fix
branch
from
6698aaa to
b2765e2
Compare
1 similar comment
|
ping @Alir3z4 |
Alir3z4
requested changes
Aug 12, 2017
| @@ -376,15 +381,38 @@ def handle_tag(self, tag, attrs, start): | |||
| self.blockquote -= 1 | |||
| self.p() | |||
|
|
|||
| def no_preceding_space(self): | |||
There was a problem hiding this comment.
Instead of using an if condition here, could this be on-line like:
def no_preceding_space(self):
return self.preceding_data and re.match(r'[^\s]', self.preceding_data[-1])
In this way the function always returns a bool.
There was a problem hiding this comment.
A small docstring would be great, although it's not necessary. The function name speaks by itself.
Good function naming
html2text/__init__.py
Outdated
| @@ -769,6 +797,19 @@ def o(self, data, puredata=0, force=0): | |||
| self.outcount += 1 | |||
|
|
|||
| def handle_data(self, data, entity_char=False): | |||
|
|
|||
|
@jonathan-s Thanks** for the great work. |
jonathan-s
force-pushed
the
emphasis-fix
branch
from
a5b2824 to
5aa7c11
Compare
6 similar comments
|
@Alir3z4 All set! Tests are passing and I made the requested changes! |
|
@jonathan-s Thanks, awesome work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues that occurs with white spaces around the following emphasis marks
~~,**,_. It's not the most beautiful code, but it fixes the bugs.