add baseurl functionality to inplace urls #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZumZoom 👍 for this. Could you please also follow https://github.com/Alir3z4/html2text/blob/master/docs/contributing.md so we can merge it right away ? |
|
Done. Also patched the same thing with |
|
Awesome, I'll be waiting to travis to finish its job and I'll be merging right away. |
| if base_fn == 'inplace_baseurl_substitution.html': | ||
| module_args['baseurl'] = 'http://brettterpstra.com' | ||
| module_args['body_width'] = 0 | ||
| # there is no way to specify baseurl in cli :( |
There was a problem hiding this comment.
@ZumZoom Would be good to add such feature?
There was a problem hiding this comment.
@Alir3z4 It depends on whether people use cli with saved html pages or not.
I use cli occasionally for testing purposes with http://* addresses only. So personally I don't need such feature.
Alir3z4
added a commit
that referenced
this pull request
Jan 31, 2016
add baseurl functionality to inplace urls Thanks Mikhail Melnik @ZumZoom
|
@ZumZoom Merged the pull-request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.