Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix get element style key error #100

Merged
merged 1 commit into from
Nov 6, 2015
Merged

🐛 fix get element style key error #100

merged 1 commit into from
Nov 6, 2015

Conversation

lovemyliwu
Copy link
Contributor

When set option google_doc = True
If element get a class, but not declared, a build-in KeyError exception will raise

@lovemyliwu
Copy link
Contributor Author

another bug fix

DistPub/html2text@5177cd1

the PR on my fork
DistPub/html2text#2

Alir3z4 added a commit that referenced this pull request Nov 6, 2015
@Alir3z4
Merge pull request #100 from DistPub/bug/get-element-style-not-check-…
bff88db 
…dict-key

🐛 fix get element style key error

Thanks Smite Chow @lovemyliwu
@Alir3z4 Alir3z4 merged commit bff88db into Alir3z4:master Nov 6, 2015
@Alir3z4
Copy link
Owner

Alir3z4 commented Nov 6, 2015

Thanks for the fix.
I'll merged it in right away.

@Alir3z4
Copy link
Owner

Alir3z4 commented Nov 6, 2015

@lovemyliwu Feel free to open up a new pull-request for your another bug-fix.

@lovemyliwu
Copy link
Contributor Author

@Alir3z4 thanks fast response, i created a new PR. #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovemyliwu @Alir3z4