-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balancing Docs between First Principles and Many Examples #296
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 78.09% 78.09%
=======================================
Files 5 5
Lines 630 630
=======================================
Hits 492 492
Misses 138 138 ☔ View full report in Codecov by Sentry. |
I put the Brusselator docs into the zoo after Cahn Hilliard. |
@quffaro, can you summarize here the steps you need to do to get this merged? |
I think the most helpful things for users would be cleaning the examples to be consistent with the latest Decapodes idiom. For example on overview.md, @GeorgeR227 and I removed the Since the examples themselves already have a lot of pedagogical value, I think an acceptable stopping point would be if
Some of the other smaller additions suggested in the issue could probably go into an FAQ section, which is on another branch. |
This draft PR proposes amending the documentation to balance a first-principles approach to documentation with the existing variety of examples showcasing Decapodes capabilities. This variety of simulations, as standalone examples of a Decapodes workflow, vary slightly in which capabilities they exhibit due to the particular differences within each scientific model.
The intent of this branch is to implement a structure specified in Issue 294, but because of the debate and scope of work, this first pass more modestly adds literate docs pages and reorders the documentation somewhat. The specific goals are:
examples
intodocs/literate
gensim
for debugging, and the world age issue I encountered when I tried to save the output ofgensim
to field in a struct)Following the discussion in the cited Issue, I've selected
ice_dynamics
as the example which is sufficiently detailed and manual-like to be the guiding example of a walk-through of specifying and running a Decapodes simulation. In doing so, I intend to curb the problem of "information overload" by prioritizing for the user a complete standalone example.This PR also moves some simulations from the
examples
folder intodocs/literate
, reviving a commented-out feature for building literate docs pages.Question Since
examples
anddocs
both exemplify Decapodes capabilities, what is the precise reason thatexamples
exists? If it is a directory of examples for users to copy and modify, then can they moved into thedocs/literate
folder so they can be rendered? If so, should thecuda
examples remain in theexamples
folder to avoid duplicating docs builds?