Adding CCDL contributors #118
Conversation
|
AppVeyor build 1.0.92 for commit 3a55ac8 is now complete. Found 1 potential spelling error(s). Preview:content/06.administrative.md:13:CSG's... |
|
My record looks good. My only question is whether we should all list ALSF as a funder? Right now only @jaclyn-taroni has it listed, but it would seem that it should apply to all or none of the CCDL folks? Or was @jaclyn-taroni funded for this project before she joined CCDL full time? |
|
@jashapiro - thank you, I forgot to bring that up. @cgreene is funded via an ALSF grant, ALSF employees are funded by ALSF but not through a grant. I agree that for ALSF employees it is all or nothing, I just forgot. |
|
I think it's probably worth having all list it. Especially since I have to list the COI. |
|
Added ALSF as a funder for all the ALSF employees in dc47c8a |
|
AppVeyor build 1.0.93 for commit dc47c8a is now complete. Found 1 potential spelling error(s). Preview:content/06.administrative.md:13:CSG's... |
|
AppVeyor build 1.0.94 for commit 5cd6104 failed. |
|
AppVeyor build 1.0.95 for commit 8528510 is now complete. Found 0 potential spelling error(s). Preview:... |
|
My record/contact information looks good in this PR 👍 . |
|
Looks good to me! |
[ci skip] This build is based on bb3493e. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/bb3493ec41abefaca8d2b41512007a23b8ac2840/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/runs/245253813
[ci skip] This build is based on bb3493e. This commit was created by the following CI build and job: https://github.com/AlexsLemonade/OpenPBTA-manuscript/commit/bb3493ec41abefaca8d2b41512007a23b8ac2840/checks https://github.com/AlexsLemonade/OpenPBTA-manuscript/runs/245253813
Purpose
Addresses #110. We're using a broad definition of
Investigationand a narrow definition ofSoftwareper #110 (comment) in these changes. I've filed #116 and #117 so we can continue the discussion about those roles, specifically.Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
@jashapiro @cansavvy and @cbethell can you carefully review your contact information please?
Is there anything that you want to discuss further?
#116 and #117 are better spots for the remaining discussion points I had, as they will impact entries other than what is being added here.
Is the pull request ready for review?
Yes.
Spellcheck Step
The dictionary used for spellchecking can be updated.
Edit the file in
build/assets/custom-dictionary.txtby adding new entries to the end.You do not need to change anything else.
However, if you want to update the first line to have an accurate count of words and you want to remove non-unique ones, run the following command from within
build/assetson your favorite OS X or Linux machine: