Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Alchemy.gem_version #111

Closed
wants to merge 2 commits into from
Closed

Drop Alchemy.gem_version #111

wants to merge 2 commits into from

Conversation

mbajur
Copy link

@mbajur mbajur commented Oct 22, 2020

I was not able to use that gem with Alchemy master thanks to the fact that Alchemy.gem_version is undefined. This change fixes it for me

@tvdeyen tvdeyen changed the base branch from master to main October 26, 2020 20:53
@tvdeyen
Copy link
Member

tvdeyen commented Oct 26, 2020

@mbajur we switched the default branch to main. I already updated this PR, but you want to pull the main branch and rebase this branch against this as well, so you get future updates. sorry for any inconvenience and thanks for the contribution.

tvdeyen added a commit to tvdeyen/alchemy-devise that referenced this pull request Nov 18, 2020
We need to `require "alchemy/version"` in these controllers to
be able to read the `Alchemy.gem_version`. This file is not
required anywhere and the method will not be defined otherwise.

Closes AlchemyCMS#111
@tvdeyen
Copy link
Member

tvdeyen commented Nov 18, 2020

Superseded by #113

@tvdeyen tvdeyen closed this Nov 18, 2020
tvdeyen added a commit that referenced this pull request Nov 22, 2020
We need to `require "alchemy/version"` in these controllers to
be able to read the `Alchemy.gem_version`. This file is not
required anywhere and the method will not be defined otherwise.

Closes #111
tvdeyen added a commit that referenced this pull request Apr 3, 2021
We need to `require "alchemy/version"` in these controllers to
be able to read the `Alchemy.gem_version`. This file is not
required anywhere and the method will not be defined otherwise.

Closes #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants