Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-combobox Dynamic menu item selection does not close dropdown after first click #78

Closed
rmenner opened this issue Nov 15, 2024 · 0 comments · Fixed by #207
Closed

auro-combobox Dynamic menu item selection does not close dropdown after first click #78

rmenner opened this issue Nov 15, 2024 · 0 comments · Fixed by #207
Assignees
@sun-mota

Comments

@rmenner
Copy link
Contributor

rmenner commented Nov 15, 2024 •
edited
Loading

Please verify the version of auro-combobox you have installed

2.1.4

Please describe the bug

(note: regular menus work)

  1. Go to Dynamic Menu example
  2. search and make a selection
  3. click again to trigger dropdown menu to close

Reproducing the error

This issue is reproducible on the Auro docsite

Expected behavior

Should close the menu after selection is made

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response
@rmenner rmenner changed the title Menu item selection does not close dropdown after first click Dynamic menu item selection does not close dropdown after first click Nov 15, 2024
@jason-capsule42 jason-capsule42 changed the title Dynamic menu item selection does not close dropdown after first click COMBOBOX: Dynamic menu item selection does not close dropdown after first click Dec 3, 2024
@jason-capsule42 jason-capsule42 transferred this issue from AlaskaAirlines/auro-combobox Dec 3, 2024
@chrisfalaska chrisfalaska removed their assignment Jan 10, 2025
@chrisfalaska chrisfalaska changed the title COMBOBOX: Dynamic menu item selection does not close dropdown after first click Dynamic menu item selection does not close dropdown after first click Jan 10, 2025
@jason-capsule42 jason-capsule42 changed the title Dynamic menu item selection does not close dropdown after first click auro-combobox Dynamic menu item selection does not close dropdown after first click Jan 10, 2025
@sun-mota sun-mota self-assigned this Jan 14, 2025
sun-mota added a commit that referenced this issue Jan 14, 2025
@sun-mota
fix: hide bib properly upon making a selecting #78
0556a81
@sun-mota sun-mota linked a pull request Jan 15, 2025 that will close this issue
fix combobox to close bib on selection and put checkmark properly #207
Merged
sun-mota added a commit that referenced this issue Jan 15, 2025
@sun-mota
fix: hide bib properly upon making a selecting #78
03f99ed
sun-mota added a commit that referenced this issue Jan 15, 2025
@sun-mota
fix: hide bib properly upon making a selecting #78
a1d66ab
jason-capsule42 pushed a commit that referenced this issue Jan 15, 2025
@semantic-release-bot
chore(release): 2.0.0-beta.7 [skip ci]
a54800f 
# [2.0.0-beta.7](v2.0.0-beta.6...v2.0.0-beta.7) (2025-01-15)

### Bug Fixes

* hide bib properly upon making a selecting [#78](#78) ([a1d66ab](a1d66ab))
* reset option on combobox.input.value change only with any variable change [#141](#141) ([fe3bfb4](fe3bfb4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sun-mota sun-mota

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix combobox to close bib on selection and put checkmark properly AlaskaAirlines/auro-formkit
4 participants
@rmenner @sun-mota @Patrick-Daly-AA @chrisfalaska