Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component registration logic #195

Closed
sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #196
Closed

Update component registration logic #195

sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #196
Assignees
Labels
auro-combobox not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@sun-mota
Copy link
Contributor

sun-mota commented Oct 17, 2024

Please verify the version of auro-combobox you have installed

No response

Please describe the bug

Default import of index.js should register the default custom element only.

import of the component class should not register the custom element at all.

Remove all registration of custom-${component name} from the JS and only register as part of ./demo/index.js

Reproducing the error

None

Expected behavior

No response

What browsers are you seeing the problem on?

No response

Additional context

Related to AlaskaAirlines/auro-menu#218

Exit criteria

No response

@sun-mota sun-mota added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-combobox labels Oct 17, 2024
@sun-mota sun-mota assigned sun-mota and unassigned Patrick-Daly-AA Oct 17, 2024
@sun-mota sun-mota linked a pull request Oct 17, 2024 that will close this issue
6 tasks
sun-mota added a commit that referenced this issue Oct 21, 2024
AuroCombobox.register is to easily register the element without extra importing
`import "@aurodesignsystem/auro-combobox"` will still register this element to <auro-combobox>
`import { AuroCombobox } from '../src/auro-combobox.js` wont register this element until AuroCombobox.register gets called
sun-mota added a commit that referenced this issue Oct 24, 2024
AuroCombobox.register is to easily register the element without extra importing
`import "@aurodesignsystem/auro-combobox"` will still register this element to <auro-combobox>
`import { AuroCombobox } from '../src/auro-combobox.js` wont register this element until AuroCombobox.register gets called
blackfalcon pushed a commit that referenced this issue Oct 24, 2024
# [2.1.0](v2.0.1...v2.1.0) (2024-10-24)

### Bug Fixes

* make `AuroCombobox` to take custom `AuroMenu` ([78bb949](78bb949))

### Features

* **api:** add register static method [#195](#195) ([6c346b1](6c346b1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-combobox not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants