Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-combobox: Theming support #153

Closed
braven112 opened this issue Oct 16, 2023 · 0 comments · Fixed by #154
Closed

auro-combobox: Theming support #153

braven112 opened this issue Oct 16, 2023 · 0 comments · Fixed by #154
Assignees
@fajar-apri-alaska @irma-kurnia-alaska
Labels
auro-combobox Type: Feature New Feature

Comments

@braven112
Copy link
Member

braven112 commented Oct 16, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231
And this auro-hyperlink pr AlaskaAirlines/auro-hyperlink#185

Exit criteria

All tokens referencing --auro have been updated.
@braven112 braven112 added not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature auro-combobox labels Oct 16, 2023
fajar-apri-alaska added a commit that referenced this issue Oct 27, 2023
@fajar-apri-alaska
perf(token): update token per new theming #153
ea60d65 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   README.md
	modified:   demo/index.html
	modified:   package.json
	modified:   src/style.scss
@fajar-apri-alaska fajar-apri-alaska mentioned this issue Oct 27, 2023
Merged
3 tasks
fajar-apri-alaska added a commit that referenced this issue Oct 27, 2023
@fajar-apri-alaska
perf(token): update token per new theming #153
b4a8f20 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   README.md
	modified:   demo/index.html
	modified:   package.json
	modified:   src/style.scss
@fajar-apri-alaska fajar-apri-alaska linked a pull request Oct 31, 2023 that will close this issue
Update CSS token per new design system theming capability #154
Merged
3 tasks
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label Nov 7, 2023
jason-capsule42 pushed a commit that referenced this issue Dec 5, 2023
@fajar-apri-alaska @jason-capsule42
perf(token): update token per new theming #153
2d99869 
- also add fallback values to provided tokens

Changes to be committed:
	modified:   README.md
	modified:   demo/index.html
	modified:   package.json
	modified:   src/style.scss
blackfalcon pushed a commit that referenced this issue Dec 5, 2023
@semantic-release-bot
chore(release): 1.8.1 [skip ci]
f6a07c5 
## [1.8.1](v1.8.0...v1.8.1) (2023-12-05)

### Performance Improvements

* **token:** update token per new theming [#153](#153) ([2d99869](2d99869))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-combobox Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CSS token per new design system theming capability AlaskaAirlines/auro-combobox
5 participants
@blackfalcon @braven112 @fajar-apri-alaska @irma-kurnia-alaska @Patrick-Daly-AA