Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor handling of empty dynamic menus #115

Closed
jason-capsule42 opened this issue Feb 2, 2023 · 0 comments · Fixed by #116
Closed

Poor handling of empty dynamic menus #115

jason-capsule42 opened this issue Feb 2, 2023 · 0 comments · Fixed by #116
Assignees
@jason-capsule42
Labels
auro-combobox not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@jason-capsule42
Copy link
Member

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Go to the doc site combobox example on a localhost
  2. View the dynamic menu example
  3. Type a letter into the menu
  4. See console log error

Expected behavior

The dynamic menu should work correctly. The bib should show.
@jason-capsule42 jason-capsule42 added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-combobox labels Feb 2, 2023
@jason-capsule42 jason-capsule42 self-assigned this Feb 2, 2023
jason-capsule42 added a commit that referenced this issue Feb 2, 2023
@jason-capsule42
fix(menu): correct handling of empty dynamic menus #115
070d7e9
jason-capsule42 added a commit that referenced this issue Feb 2, 2023
@jason-capsule42
Revert "fix(menu): correct handling of empty dynamic menus #115"
aa78caf 
This reverts commit 070d7e9.
jason-capsule42 added a commit that referenced this issue Feb 2, 2023
@jason-capsule42
fix(menu): correct handling of empty dynamic menus #115
ec6dd24
@jason-capsule42 jason-capsule42 mentioned this issue Feb 2, 2023
Merged
6 tasks
@jason-capsule42 jason-capsule42 linked a pull request Feb 2, 2023 that will close this issue
fix(menu): correct handling of empty dynamic menus #115 #116
Merged
6 tasks
jordanjones243 pushed a commit that referenced this issue Feb 3, 2023
@jason-capsule42 @jordanjones243
fix(menu): correct handling of empty dynamic menus #115
0409bb8
blackfalcon pushed a commit that referenced this issue Feb 7, 2023
@semantic-release-bot
chore(release): 1.7.1 [skip ci]
51a3191 
## [1.7.1](v1.7.0...v1.7.1) (2023-02-07)

### Bug Fixes

* **error:** dont remove error attribute when choosing a menu value [#111](#111) ([c421969](c421969))
* **menu:** correct handling of empty dynamic menus [#115](#115) ([0409bb8](0409bb8))

### Performance Improvements

* **actions:** update pipeline dependencies ([e2c7883](e2c7883))
* **deps:** update to latest deps versions ([895afdb](895afdb))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

Labels
auro-combobox not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu): correct handling of empty dynamic menus #115 AlaskaAirlines/auro-combobox
1 participant
@jason-capsule42