Simplify cookie extraction

AikidoSec · Feb 28, 2025 · 1ff11e9 · 1ff11e9
1 parent 89657ec
commit 1ff11e9
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/agent/src/main/java/dev/aikido/agent/wrappers/spring/SpringMVCWrapper.java b/agent/src/main/java/dev/aikido/agent/wrappers/spring/SpringMVCWrapper.java
@@ -18,6 +18,7 @@
 import dev.aikido.agent_api.helpers.logging.Logger;
 
 import java.lang.reflect.Executable;
+import java.util.ArrayList;
 import java.util.Enumeration;
 import java.util.HashMap;
 import java.util.List;
@@ -73,15 +74,11 @@ public static Object interceptOnEnter(
             Cookie[] cookies = request.getCookies();
             if (cookies != null) {
                 for (Cookie cookie : cookies) {
-                    List<String> newValue;
-                    // If the cookie is already inside the map, add the value to the existing list
-                    if (cookiesMap.containsKey(cookie.getName())) {
-                        newValue = cookiesMap.get(cookie.getName());
-                        newValue.add(cookie.getValue());
-                    } else {
-                        newValue = List.of(cookie.getValue());
+                    // If no entry exists, create a new empty entry
+                    if (!cookiesMap.containsKey(cookie.getName())) {
+                        cookiesMap.put(cookie.getName(), new ArrayList<>());
                     }
-                    cookiesMap.put(cookie.getName(), newValue);
+                    cookiesMap.get(cookie.getName()).add(cookie.getValue());
                 }
             }