Update Getting Started Section to Use dapp-card-store #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b2543db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8472d24f.documentation-7tp.pages.dev |
| Branch Preview URL: | https://getting-started-card-store.documentation-7tp.pages.dev |
ivanlei
force-pushed
the
getting_started_card_store
branch
from
a56ae7c to
aa21df7
Compare
Tyrosine22
suggested changes
Apr 7, 2023
| - node version: 12.x is too old; use 14.15.0 or higher | ||
| - skip `git checkout hackathon-2020-11`; use the default `master` branch | ||
| - node version: 12.x is too old; use 16.19.1 or higher | ||
| - skip `git checkout hackathon-2020-11`; use the `community-dev` branch | ||
|
|
There was a problem hiding this comment.
Have you verified that Agoric now requires this later version of Node?
There was a problem hiding this comment.
Yes. This is the requirement in agoric-sdk. See https://github.com/Agoric/agoric-sdk/blob/master/package.json#L36
| ## Connect the Dapp to the Agoric Wallet | ||
|  | ||
|
|
||
| 1. Navigate back to [http://127.0.0.1:8000](http://127.0.0.1:8000) and accept the Dapp's request to connect to your wallet. |
There was a problem hiding this comment.
We should be consistent in how we capitalize "dapp". I'm in favor of lowercase, but an argument could be made to capitalize, I suppose. (If it's good enough for the Germans, who are we to argue?)
Tyrosine22
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Getting Started Section to Use dapp-card-store
Description
The card store dapp is considered a "more interesting" dapp because it uses Zoe. Let's update the instructions in getting started to use card store.
Testing
Tested locally on clean checkout