-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deposit ist from provision dialog #227
Conversation
@samsiegart the one change I would make (and you might already be doing it but not visible here) is some logic around when a user can click 'Proceed'. I think it's better UX to not let them attempt the transaction by hitting 'Proceed' until they have at least 1IST balance to cover the smart wallet provisioning. So we should only illuminate the button when they have that required balance. |
6dec831
to
ed11014
Compare
To interact with contracts on the Agoric chain, a smart wallet must be | ||
created for your account. As an anti-spam measure, you will need{' '} | ||
{smartWalletFeeForDisplay && <b>{smartWalletFeeForDisplay}</b>} to fund | ||
its provision which will be deposited into the reserve pool. Click | ||
"Proceed" to provision wallet and submit transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To interact with contracts on the Agoric chain, a smart wallet must be | |
created for your account. As an anti-spam measure, you will need{' '} | |
{smartWalletFeeForDisplay && <b>{smartWalletFeeForDisplay}</b>} to fund | |
its provision which will be deposited into the reserve pool. Click | |
"Proceed" to provision wallet and submit transaction. | |
To interact with contracts on the Agoric chain, a smart wallet must be | |
created for your account. You will need{' '} | |
{smartWalletFeeForDisplay && <b>{smartWalletFeeForDisplay}</b>} to fund | |
its provision which will be deposited into the reserve pool. Click | |
"Proceed" to provision wallet and submit transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into #252 while testing, but appears to be unrelated. LGTM after the copy edit.
fixes #244