Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deposit ist from provision dialog #227

Merged
merged 3 commits into from
Mar 14, 2024
Merged

feat: deposit ist from provision dialog #227

merged 3 commits into from
Mar 14, 2024

Conversation

samsiegart
Copy link
Collaborator

@samsiegart samsiegart commented Jan 23, 2024

fixes #244

Screenshot 2024-03-14 at 10 27 40 AM

Copy link

github-actions bot commented Jan 23, 2024

Network:
Commit: aa28174
Ref: refs/heads/main
IPFS v1 hash: bafybeid6mivism3zbaybc4lvu55vf7koadq4p3jseswjozxfdabfsz2mum
CF - DWeb - 4EVERLAND

@samsiegart samsiegart marked this pull request as draft January 23, 2024 18:55
@otoole-brendan
Copy link

@samsiegart the one change I would make (and you might already be doing it but not visible here) is some logic around when a user can click 'Proceed'. I think it's better UX to not let them attempt the transaction by hitting 'Proceed' until they have at least 1IST balance to cover the smart wallet provisioning. So we should only illuminate the button when they have that required balance.

To interact with contracts on the Agoric chain, a smart wallet must be
created for your account. As an anti-spam measure, you will need{' '}
{smartWalletFeeForDisplay && <b>{smartWalletFeeForDisplay}</b>} to fund
its provision which will be deposited into the reserve pool. Click
&quot;Proceed&quot; to provision wallet and submit transaction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To interact with contracts on the Agoric chain, a smart wallet must be
created for your account. As an anti-spam measure, you will need{' '}
{smartWalletFeeForDisplay && <b>{smartWalletFeeForDisplay}</b>} to fund
its provision which will be deposited into the reserve pool. Click
&quot;Proceed&quot; to provision wallet and submit transaction.
To interact with contracts on the Agoric chain, a smart wallet must be
created for your account. You will need{' '}
{smartWalletFeeForDisplay && <b>{smartWalletFeeForDisplay}</b>} to fund
its provision which will be deposited into the reserve pool. Click
&quot;Proceed&quot; to provision wallet and submit transaction.

Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into #252 while testing, but appears to be unrelated. LGTM after the copy edit.

@samsiegart
Copy link
Collaborator Author

@ivanlei I updated the text in the dialog per @raphdev 's suggestion, lmk if this looks good to you.

@samsiegart
Copy link
Collaborator Author

Ran into #252 while testing, but appears to be unrelated. LGTM after the copy edit.

The breaking change has now been reverted and this PR has been rebased

@samsiegart samsiegart merged commit aa28174 into main Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IST balance and 'Get IST' button to provision dialog
4 participants