scope restricted-syntax #7323
Merged
scope restricted-syntax #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/scope-restricted-syntax
branch
from
ac3e258 to
d7e9c11
Compare
dckc
reviewed
Apr 5, 2023
| * loanTiming: LoanTiming, | ||
| * interestTiming: InterestTiming, |
There was a problem hiding this comment.
That's a breaking change to the RPC API, isn't it?
Seems like it would show up a chainStorage snapshot test if we had one for this part of published.
There was a problem hiding this comment.
Hmm, I'll look into this. Meanwhile I'll take the commit out of this PR.
They're more important and the terminology warnings in tests were hiding more substantial warnings. In inter-protocol this cut 535 terminology warnings in tests, leaving 180 in produc/exported code
turadg
force-pushed
the
ta/scope-restricted-syntax
branch
from
d7e9c11 to
4630a1f
Compare
turadg
added
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The no-restricted-syntax warning on tests was making a wall of warnings in my IDE, making it harder to notice more substantive ones. Some of the rules don't apply to test code (like "RUN", which is fine for tests).
So this changes the rule to apply only to product / exported code. We should prioritize burning those down and getting to 'error' so they can't reappear. Then we can decide what policy we want for tests. Most of the ones in tests will be solved by changing the code under test.
This also burns down the InterestTiming configuration.
Security Considerations
--
Scaling Considerations
--
Documentation Considerations
--
Testing Considerations
CI