Consistently generate build tags on Make 4.3+ #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Feb 25, 2023
michaelfig
added
automerge:squash
With Make 4.3+, the empty whitespace does not seem to work as originally intended. Agoric SDK only uses one build tag "ledger" and therefore does not currently experience malformed tags. However, on Gaia (Cosmoshub) it was identified that build tags were produced as "netgo ledger," on Ubuntu 22.04 and other systems that include the newer Make version. The build tags were originally intended as "netgo,ledger" which can be observed on Make 4.2 (shipped with Ubuntu 20.04). This change ensures that in future, if Agoric decides to expand on build tags, it will work consistently across old and new systems. This change swaps out the `+=` use in favor of an explicit `:=`. Ref: https://www.gnu.org/software/make/manual/html_node/Appending.html Upstream: cosmos/gaia@297cdb9
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
mhofman
force-pushed
the
build_tags_make_4_3
branch
from
64097e0 to
9f67387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: cosmos/gaia#2017
Description
With Make 4.3+, the empty whitespace does not seem to work as originally intended. Agoric SDK only uses one build tag
"ledger"and therefore does not currently experience malformed tags.However, on Gaia (Cosmoshub) it was identified that build tags were produced as
"netgo ledger,"on Ubuntu 22.04 and other systems that include the newer Make version. The build tags were originally intended as"netgo,ledger"which can be observed on Make 4.2 (shipped with Ubuntu 20.04).This change ensures that in future, if Agoric decides to expand on build tags, it will work consistently across old and new systems.
This change swaps out the
+=use in favor of an explicit:=. (Make Reference)Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
None.