fix: swingset amino codec / Ledger support #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Oct 4, 2022
dckc
changed the title
|
Now that |
dckc
force-pushed
the
dc-ledger-amino-oops
branch
from
72fc1f6 to
8d7238d
Compare
dckc
added
automerge:no-update
dckc
force-pushed
the
dc-ledger-amino-oops
branch
from
8d7238d to
223b45d
Compare
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6347
refs: #3628
Description
Fix amino codec details both in
x/swingsetandwallet/ui.Also, avoid collisions with
agoricchain name in Keplr.Security Considerations
Being able to use a Ledger is a pretty big security feature :)
Documentation Considerations
@rowgraus I guess this should go in the user docs?
Big thanks to the Keplr folks for diagnosing the problem!
Testing Considerations
@michaelfig tested
agdand the wallet UI; I also tested the wallet UI.@turadg wondered about integration testing with zemu. I'm inclined to leave that out of scope.