-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Passable collections #587
Conversation
Read in order:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know that it's worth blocking you from merging, but I think you should fix the allocation thing in finalStore
(unless I'm actually misunderstanding what's going on, which is certainly possible).
Also refactored store and weakStore. Added some tests.
2cfc46d
to
b251724
Compare
Fixed. If this was a "conversation" I'd say "Resolve conversation". |
This is a ping from your friendly neighbourhood housekeeper. Is this PR still relevant? If so, but you're not prepared to act on it, could we temporarily close it and make an issue that points to it? |
@michaelfig |
Closing in favor of #3531 |
Fixes #16
Working my way up to passable sets and maps indexed by sameStructure equivalence. This will let us express our setMathHelpers naturally and efficiently. Not there yet.
The draft proposed changes to our store apis, and the new trieStore, are here and interesting. The diverge/snapshot/readOnly methods are based on https://github.com/tc39/proposal-readonly-collections
NOT URGENT. Just a curiosity until we're past Zoe alpha.