Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Passable collections #587

Closed
wants to merge 5 commits into from
Closed

WIP: Passable collections #587

wants to merge 5 commits into from

Conversation

erights
Copy link
Member

@erights erights commented Feb 21, 2020

Fixes #16

Working my way up to passable sets and maps indexed by sameStructure equivalence. This will let us express our setMathHelpers naturally and efficiently. Not there yet.

The draft proposed changes to our store apis, and the new trieStore, are here and interesting. The diverge/snapshot/readOnly methods are based on https://github.com/tc39/proposal-readonly-collections

NOT URGENT. Just a curiosity until we're past Zoe alpha.

@erights erights changed the base branch from no-config-add-brand to master February 21, 2020 04:26
@erights
Copy link
Member Author

erights commented Feb 21, 2020

Read in order:

  • weakStore.js
  • store.js
  • trieStore.js

packages/store/src/trieStore.js Outdated Show resolved Hide resolved
packages/store/src/trieStore.js Show resolved Hide resolved
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know that it's worth blocking you from merging, but I think you should fix the allocation thing in finalStore (unless I'm actually misunderstanding what's going on, which is certainly possible).

Also refactored store and weakStore.
Added some tests.
@erights erights force-pushed the passable-collections branch from 2cfc46d to b251724 Compare March 7, 2020 00:00
@erights
Copy link
Member Author

erights commented Mar 7, 2020

Don't know that it's worth blocking you from merging, but I think you should fix the allocation thing in finalStore (unless I'm actually misunderstanding what's going on, which is certainly possible).

Fixed. If this was a "conversation" I'd say "Resolve conversation".

@erights erights self-assigned this Apr 8, 2020
@katelynsills katelynsills removed their request for review November 19, 2020 16:38
@michaelfig
Copy link
Member

This is a ping from your friendly neighbourhood housekeeper.

Is this PR still relevant? If so, but you're not prepared to act on it, could we temporarily close it and make an issue that points to it?

@erights
Copy link
Member Author

erights commented Feb 18, 2021

@michaelfig
I'm going to keep this one open in the icebox as it has an interesting start on some relevant collection technology. But if I use it, it'll probably start new PRs and just keep this one for reference.

@erights
Copy link
Member Author

erights commented Jul 26, 2021

Closing in favor of #3531

@erights erights closed this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mechanism to marshal immutable Set/Map
3 participants