Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ertp): remove unneeded ertp type imports #10467

Merged
merged 3 commits into from
Nov 14, 2024
Merged

fix(ertp): remove unneeded ertp type imports #10467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8214a20
fix(ertp): remove unneeded ertp type imports
erights Nov 13, 2024
ee37cf1
fixup! deprecated reexport of Baggage no longer needed
erights Nov 13, 2024
fe06d31
Merge branch 'master' into markm-remove-unneeded-ertp-type-imports
mergify[bot] Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ERTP/src/amountStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { AmountMath } from './amountMath.js';

/** @import {Amount, AssetKind, AmountValue, AssetKindForValue, AssetValueForKind, Brand, MathHelpers} from './types.js' */
/** @import {Amount, AssetKind} from './types.js' */

/**
* @template {AssetKind} [K=AssetKind]
Expand Down
7 changes: 0 additions & 7 deletions packages/ERTP/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,5 @@ export * from './amountMath.js';
export * from './issuerKit.js';
export * from './typeGuards.js';

/**
* Importing Baggage from `@agoric/ertp` is deprecated. Import Baggage from
* `@agoric/vat-data` instead
*
* @import {Baggage} from '@agoric/vat-data'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only questionable one. See the discussion under "Upgrade Considerations" in the PR comment.

*/

// eslint-disable-next-line import/export
export * from './types-index.js';
2 changes: 1 addition & 1 deletion packages/ERTP/src/legacy-payment-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { AmountMath } from './amountMath.js';

/**
* @import {ERef} from '@endo/far';
* @import {Amount, AssetKind, AmountValue, AssetKindForValue, Payment, Brand, Purse} from './types.js';
* @import {Amount, AssetKind, Payment, Purse} from './types.js';
*/

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/ERTP/src/purse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { AmountMath } from './amountMath.js';
import { makeTransientNotifierKit } from './transientNotifier.js';
import { makeAmountStore } from './amountStore.js';

/** @import {Amount, AssetKind, AmountValue, AssetKindForValue, RecoverySetsOption, Brand, Payment} from './types.js' */
/** @import {AssetKind, RecoverySetsOption, Brand, Payment} from './types.js' */

const EMPTY_COPY_SET = makeCopySet([]);

Expand Down
2 changes: 1 addition & 1 deletion packages/ERTP/src/transientNotifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { makeNotifierKit } from '@agoric/notifier';

/**
* @import {Purse} from './types.js';
* @import {LatestTopic, NotifierRecord} from '@agoric/notifier';
* @import {NotifierRecord} from '@agoric/notifier';
*/

// Note: Virtual for high cardinality, but *not* durable, and so
Expand Down
Loading