ci: Retain complete a3p-integration directories and resulting slogfiles #10446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
force-pushed
the
gibson-2024-11-retain-a3p-slogfile
branch
from
03548f6 to
d3782f1
Compare
Deploying agoric-sdk with
|
| Latest commit: |
1f88aff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bacc76cc.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-11-retain-a3p-sl.agoric-sdk.pages.dev |
michaelfig
reviewed
Nov 12, 2024
.github/workflows/integration.yml
Outdated
| # Copy everything from the $dir to the destination directory | ||
| cp -r "$dir"/* "$destination_dir/" | ||
| echo "Copied contents of $dir to $destination_dir" | ||
| # Copy everything from a3p-integration to /tmp/export/a3p-integration |
There was a problem hiding this comment.
Hmmmm. While it is impressive that you are performing this feat with both hands tied behind your back (with Bash under YAML), would it be easier to call a Node.js script leveraging execa instead?
There was a problem hiding this comment.
Meh, no strong feelings either way. I kept it like this as an evolution of what was already there, but am equally happy to change it.
There was a problem hiding this comment.
Okay, let's split the difference, and excise the YAML. Can you factor out the Bash into a file like agoric-sdk/scripts/$something.sh, and call it from the workflow?
michaelfig
approved these changes
Nov 13, 2024
gibson042
force-pushed
the
gibson-2024-11-retain-a3p-slogfile
branch
from
d2ea86e to
5ff5001
Compare
gibson042
force-pushed
the
gibson-2024-11-retain-a3p-slogfile
branch
from
5ff5001 to
7bbfd9d
Compare
gibson042
force-pushed
the
gibson-2024-11-retain-a3p-slogfile
branch
from
7bbfd9d to
1f88aff
Compare
mergify bot
added a commit
that referenced
this pull request
Nov 14, 2024
…#10466) ## Description Resolving some confusion I experienced while debugging #10165 and working on #10446. * refactor build-submission.sh to be working-directory-aware and accept an arbitrary number of additional arguments * document build-submission.sh w.r.t. package.json "agoricProposal" * document build-all-submissions.sh w.r.t. `./proposals?:*` * add explanatory output to build-all-submissions.sh * explain all of the above in the README ### Security Considerations None known. ### Scaling Considerations n/a ### Documentation Considerations Included in the README and shell scripts. ### Testing Considerations These scripts are covered by integration testing. ### Upgrade Considerations None known; a3p-integration should be self-contained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #10165 and dependent upon Agoric/agoric-3-proposals#193 .
This expands
test-docker-buildCI job artifacts from just core eval scripts to their containing a3p-integration directory plus the job's slogfile.Security Considerations
n/a
Scaling Considerations
The final slogfile from #10165 was about 67 MB, which is smaller than the 161 MB deployment-test-results artifact. But regardless, I've limited retention to
4 days on success/10 days on failure10 days, and we could also compress before upload if even that is too much.Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
n/a