Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FU multichain testing of happy path #10597

Closed
3 tasks
Tracked by #10595
turadg opened this issue Dec 2, 2024 · 0 comments · Fixed by #10618
Closed
3 tasks
Tracked by #10595

FU multichain testing of happy path #10597

turadg opened this issue Dec 2, 2024 · 0 comments · Fixed by #10618
Assignees
@0xpatrickdev
Labels
test
Milestone
FU3: multichain i...

Comments

@turadg
Copy link
Member

turadg commented Dec 2, 2024 •
edited by 0xpatrickdev
Loading

What is the Problem Being Solved?

Need test coverage of Fast USDC through multichain transactions in CI

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
@turadg turadg added the test label Dec 2, 2024
@turadg turadg added this to the FU3: multichain integration milestone Dec 2, 2024
@dckc dckc mentioned this issue Dec 2, 2024
Closed
1 task
This was referenced Dec 4, 2024
Merged
Merged
mergify bot added a commit that referenced this issue Dec 6, 2024
@mergify
chore: fusdc multichain support (#10626)
ef9088c 
refs: #10597

## Description

Primary changes:

- `@agoric/orchestration`: exposes `intermediateRecipient: ChainAddress['value']` in `ForwardOpts`, part of `IBCMsgTransferOpts`, allowing callers to provide their own value. Currently defaults to `"pfm"`
- `@agoric/fast-usdc`: creates a Noble ICA in the `StartFn` so we have an address value for `intermediateRecipient`. Noble's chain does not permit non-bech32 values.

Ancillary: 
- `@agoric/boot`'s `bridgeUtils` helpers:
   - `setAckBehavior` helper to control whether a `IBCDowncallMethod` acknowledgments are queued or inbounded immediately
   - `setBech32Prefix` helper to control address prefix for ICA accounts
   - ICA addresses are unique per account
- `@agoric/fast-usdc`: remove `blockTimestamp` from `CctpTxEvidence`


### Security Considerations
No new considerations

### Scaling Considerations
None

### Documentation Considerations
None

### Testing Considerations
Updated existing tests.

### Upgrade Considerations
N/A, library code part of FUSDC or NPM Orch release
@mergify mergify bot closed this as completed in #10618 Dec 13, 2024
@mergify mergify bot closed this as completed in c7a005e Dec 13, 2024
@0xpatrickdev 0xpatrickdev mentioned this issue Dec 13, 2024
Merged
mergify bot added a commit that referenced this issue Dec 17, 2024
@mergify
test(multichain): fusdc "advance and settle" as a macro (#10692)
9e124c3 
refs: #10597

## Description
- tests additional FUSDC happy paths with agoric and noble EUDs
- "oracles accept" test conditionally accepts invitations

### Security Considerations
None, only tests

### Scaling Considerations
None, ~60s hit to CI (each advance + settle is about 30s)

### Documentation Considerations
None

### Testing Considerations
PR is only tests

### Upgrade Considerations
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xpatrickdev 0xpatrickdev

Labels
test
Projects
None yet
Milestone
FU3: multichain integration
Development

Successfully merging a pull request may close this issue.

test: fusdc multichain Agoric/agoric-sdk
2 participants
@turadg @0xpatrickdev