[#1] Rockstar Validation

[OvidiuBan]

No description provided.

[cristi-badila]

When calling getMessage you are essentially calling the validation method (be it either nameRequired, instrumentRequired or any other method) a second time (it was already called in isValid). Try to come up with a design which runs the validation rules only once.

[alexandru-calinoiu]

We also need composite rules, rules made out of multiple rules.

[cristi-badila]

This seems to be the same code as in nameRequired except with a different property name. If you were to rename nameRequired to stringRequired and it would receive the attribute as a parameter you would have no more duplication.

[alexandru-calinoiu]

Something is not right yet, for me functional means that everything is a function, something like this:

  // Use a Promise-based library to do IO.
  var http = require("q-io/http")
     ,noop = new Promise(()=>{})
     ,prepare =
        (str)=> http.read('http://www.example.com/' + str)
                  .then((res)=> res.body.toString())
                  // the 'then' is equal to the '>>'
     ,makeQuery = 
        (strs)=> strs.map((str)=> prepare(str))
     ,doQuery = 
        (qrys)=> qrys.reduce((results, qry)=> results.then(qry), noop)
     ,stmts = [ "articles/FunctionalJavaScript"
              , "blob/c745ef73-ece9-46da-8f66-ebes574789b1"
              , "books/language/Haskell"
              ]
     ,main = doQuery(makeQuery(stmts));