Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[AGE-1486]: Illegal react operation due to changed order of rendered hooks #2413

Merged
merged 6 commits into from
Jan 24, 2025
Merged

(frontend)[AGE-1486]: Illegal react operation due to changed order of rendered hooks #2413

merged 6 commits into from
Jan 24, 2025

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jan 8, 2025

Closes AGE-1486

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:03pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:03pm

@bekossy bekossy marked this pull request as ready for review January 9, 2025 11:03
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Frontend labels Jan 9, 2025
@bekossy bekossy requested a review from ardaerzin January 14, 2025 09:22
ardaerzin
ardaerzin requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small cleanup request 🙏

agenta-web/src/components/Layout/Layout.tsx Outdated Show resolved Hide resolved
@bekossy bekossy requested a review from ardaerzin January 14, 2025 11:38
ardaerzin
ardaerzin approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bekossy LGTM 👍

@mmabrouk mmabrouk merged commit c6772f8 into dev Jan 24, 2025
5 of 6 checks passed
aybruhm pushed a commit that referenced this pull request Feb 13, 2025
@mmabrouk
Merge pull request #2413 from Agenta-AI/AGE-1486/-illegal-react-opera…
d3d0d9b 
…tion-due-to-changed-order-of-rendered-hooks

(frontend)[AGE-1486]: Illegal react operation due to changed order of rendered hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaerzin ardaerzin ardaerzin approved these changes

Assignees
No one assigned
Labels
Frontend size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekossy @ardaerzin @mmabrouk