Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[AGE 1473]: Vault WebUI <> API Integration #2380

Merged
merged 22 commits into from
Dec 20, 2024
Merged

(frontend)[AGE 1473]: Vault WebUI <> API Integration #2380

merged 22 commits into from
Dec 20, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Dec 17, 2024

Closes AGE-1473

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:38am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:38am

@bekossy bekossy changed the base branch from dev to feature/vault December 17, 2024 03:11
Base automatically changed from feature/vault to dev December 17, 2024 08:18
@ardaerzin ardaerzin self-requested a review December 19, 2024 10:40
ardaerzin
ardaerzin approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ardaerzin ardaerzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes 🙏 👍

aybruhm
aybruhm approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA'ed OSS, everything looks good to me.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@bekossy bekossy merged commit 171fc7c into dev Dec 20, 2024
6 checks passed
@bekossy bekossy deleted the checkpoint-2-vault-webui-and-api-integration branch December 20, 2024 12:52
@jp-agenta jp-agenta restored the checkpoint-2-vault-webui-and-api-integration branch December 20, 2024 14:04
@jp-agenta jp-agenta mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaerzin ardaerzin ardaerzin approved these changes

@aybruhm aybruhm aybruhm approved these changes

@mmabrouk mmabrouk Awaiting requested review from mmabrouk

Assignees
No one assigned
Labels
Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bekossy @ardaerzin @aybruhm