Add useOnClickOutside hook #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jarrisondev is attempting to deploy a commit to the aforina's projects Team on Vercel. A member of the Team first needs to authorize it. |
Zyruks
added
the
Type: Enhancement
MarcosNASA
approved these changes
Apr 7, 2024
| type Event = MouseEvent | TouchEvent; | ||
|
|
||
| export const useOnClickOutside = (ref: RefObject<HTMLElement>, handler: (event: Event) => void) => { | ||
| useEffect(() => { |
There was a problem hiding this comment.
🟢 I'd suggest using the latest ref pattern to avoid forcing the consumer of the hook to memoize the handler function to avoid the event from being bound and unbound on every rerender.
You can see an example here,
|
Very good PR Jarri! Amazing!! Thanks a lot for the contribution 😁! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made 🎉
Describe Changes
Related Issue(s)
#86
Visuals (Optional)
Checklist ✅