Feat: Add the countdown account in the Hero component #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LUISEDOCCOR is attempting to deploy a commit to the aforina's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Bastante cool queda, agregaría un text-shadow para que no se pierda tanto el texto con el fondo. |
|
+1 to zyruks comment!! do we contemplate how it looks when im streaming? |
|
Sorry, I had not considered the component when you are live. I'll review the conflicts and check that. Thanks! 💫 |
|
Thank u a lot! :3 |
MarcosNASA
reviewed
Apr 7, 2024
| <span className="font-bold text-6xl">{formatNumber(timeLeft.seconds)}</span> | ||
| </section> | ||
| {time.map(({ name, label }, index) => ( | ||
| <section key={index} className="text-center text-shadow-sm"> |
There was a problem hiding this comment.
🟢 The name would likely be a better key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the countdown account in the Hero component
Before: 🚀
After: ✨
When Afor is live 👑:
When afor is not live 😥: