feat: add Ticket api integration #115
Conversation
|
@luisya22 is attempting to deploy a commit to the aforina's projects Team on Vercel. A member of the Team first needs to authorize it. |
src/pages/_sections/Ticket.tsx
Outdated
| return; | ||
| } | ||
|
|
||
| await uploadTicket(providerId, ticketId, img); |
There was a problem hiding this comment.
@afordigital @Zyruks @jarrisondev do you think it is necessary to persist the ticket if it only downloads the image (taking into account that downloading does not require persisting)?
There was a problem hiding this comment.
You mean you don't need to save it because it will always make the call to the database?
There was a problem hiding this comment.
I mean, there are 2 buttons "Compartir" and "Descargar Ticket", the functionality to persist the image for later use as OG only serves if you want to share it on a social network (in this case in the "Compartir" button via Twitter), the action of "Descargar Ticket" is not necessary the functionality to persist and OG
In my case, I do not have Twitter, but if I want to download the ticket (to download, it is only to make a "screenshot" of the ticket and save it in the pc), in these cases it is not necessary to save in DB or anything
There was a problem hiding this comment.
Agreed - I don't think persisting the ticket image is necessary unless it's shared via Twitter.
|
Amazing PR luis, thank you for all the time and the contribution! |
uploadTicket from image dowload, change update to upsert when updating ticket
|
The new commit resolve most of the requested changes. The only remaining concern is how are we going to implement the rate limiting for image upload. |
| @@ -4,8 +4,9 @@ import { FC, RefObject, useRef } from 'react'; | |||
| import { Variant } from '@common'; | |||
There was a problem hiding this comment.
🟢 Nit: it would be awesome if downloadTicket and shareTwitter didn't depend on React-specifics (refs) but on the DOM elements directily.
There was a problem hiding this comment.
This means that I should use getElementById?
There was a problem hiding this comment.
const downloadTicket = async (element: HTMLElement, ticketId: string | null, providerId: string | null) => {
// TODO: Send Generated Image to Supabase
if (ticketId && providerId) {
try {
const img = await toBlob(element);
const dataUrl = await toPng(elementRef.current);
if (!img) {
console.error(); // TODO: Alert
return;
}
const link = document.createElement('a');
link.download = 'hackafor-ticket.png';
link.href = dataUrl;
};
---
// Consuming it
if (!elementRef.current) return
downloadTicket(elementRef.current, ...)This way, the downloadTicket function is no longer React-dependent. But again, it's a super nit, feel free to ignore!
There was a problem hiding this comment.
Thanks for your recommendation, I'll implement this.
src/pages/_sections/Ticket.tsx
Outdated
| return; | ||
| } | ||
|
|
||
| await uploadTicket(providerId, ticketId, img); |
There was a problem hiding this comment.
Agreed - I don't think persisting the ticket image is necessary unless it's shared via Twitter.
|
|
||
| if (_event == 'INITIAL_SESSION') { | ||
| getUserTicket(session.user.id) | ||
| .then((ticket) => { |
There was a problem hiding this comment.
❓ I remember we mentioned we would want to persist Ticket entries (without image) as soon as someone logs-in for the first time so that logging in claims your ticket number - was this achieved in a different way?
There was a problem hiding this comment.
Yes, this was achieved using a trigger directly on Supabase
Changes Made 🎉
Describe Changes
Integration with Supabase API to get Ticket information.
Add placeholder for image upload.
Visuals (Optional)
Checklist ✅