Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fstab output #5

Closed
ermo opened this issue Jul 10, 2024 · 0 comments
Closed

Improve fstab output #5

ermo opened this issue Jul 10, 2024 · 0 comments
Labels
priority: immediate Should be immediately addressed. type: enhancement New feature or request

Comments

@ermo
Copy link
Contributor

ermo commented Jul 10, 2024

Ikey Doherty
Can someone remind me later please to ensure we have proper uuid string in fstab, respecting partuuid, and to make it add a comment showing the device path

Done.
@ermo ermo added the type: enhancement New feature or request label Jul 10, 2024
@ermo ermo added the priority: immediate Should be immediately addressed. label Jul 10, 2024
ikeycode added a commit that referenced this issue Jul 10, 2024
@ikeycode
installer: Fix issue #5, improving fstab output
b337bbd 
We know all of our *supported* partitions are on GPT disks so we can safely assert
PARTUUID entries in the fstab. We also add a comment for the administrator to let
them know what block device (path) was used at the time of installation, ie what
maps to the PARTUUID.

Signed-off-by: Ikey Doherty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: immediate Should be immediately addressed. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ermo @ikeycode