Add adjustAuthorisation to modification models #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgegg
force-pushed
the
add-modification-adjust-authorisation
branch
from
9c9351c to
e4031da
Compare
|
HI @georgegg, Thanks for the PR! We will review it and if no remarks are there we will merge it into the code. Regards, |
rikterbeek
requested review from
rikterbeek,
Aleffio,
lancergr and
maassenbas
Aleffio
reviewed
Feb 14, 2018
src/Adyen/Service/Modification.php
Outdated
| @@ -9,6 +9,7 @@ class Modification extends \Adyen\Service | |||
| protected $_cancelOrRefund; | |||
| protected $_capture; | |||
| protected $_refund; | |||
| protected $_adjustAthorisation; | |||
There was a problem hiding this comment.
Can you please just add a 'u' in "_adjustAthorisation"?
Thanks for the PR!
|
Hi @Aleffio, I fixed my typo. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to use the API call for
adjustAuthorisationin v30.So I added the modification method in the php library.
Tested scenarios
I created two tests in
ModificationTest.phpthat increases and decreases the previously authorised amount.Fixed issue: