Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary code snippets. #48

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

nursultanturdaliev
Copy link
Contributor

Only did a little bit code cleaning.

@rikterbeek
Copy link
Contributor

Hi @nursultanturdaliev,

Thanks for the PR!. I think it is nice to include the headers as well into the requestPost method. Instead of remove it could you add this line into your PR:
curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);

Regards,
Rik
Adyen

@nursultanturdaliev
Copy link
Contributor Author

Hi @rikterbeek

Added headers as requested. Looks like my git account is different on my local machine. Because I did second commit locally then pushed.

@rikterbeek rikterbeek self-requested a review January 25, 2018 14:51
@rikterbeek
Copy link
Contributor

Hi @nursultanturdaliev

Great thanks. I will merge it.

Regards,
Rik
Adyen

@rikterbeek rikterbeek merged commit b19d2d1 into Adyen:develop Jan 25, 2018
@rikterbeek rikterbeek mentioned this pull request Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants