Feature/gh refund with data #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Adyen/Service/Modification.php
Outdated
| @@ -24,6 +24,11 @@ class Modification extends \Adyen\Service | |||
| */ | |||
| protected $refund; | |||
|
|
|||
| /** | |||
| * @var ResourceModel\Modification\Refund | |||
There was a problem hiding this comment.
Suggested change
| * @var ResourceModel\Modification\Refund | |
| * @var ResourceModel\Modification\RefundWithData |
|
Hi @sufcboy , Thank you for the PR, we are going to review it and then merge it. Best, |
cyattilakiss
requested review from
Aleffio,
rikterbeek,
rkewlani,
AlexandrosMor,
KadoBOT and
martinsrenato
Aleffio
approved these changes
May 23, 2019
rkewlani
approved these changes
Jun 4, 2019
|
HI @sufcboy, Many thanks for the PR! It looks good and we can merge it. It would be great to have some test cases alongside this are you able to add this ? Regards, |
|
I've added a single success path test. This corresponds to the fund test. |
rikterbeek
approved these changes
Jun 7, 2019
|
HI @sufcboy, Thanks! I will merge this. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested scenarios
Fixed issue: