Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SH Runner False Negative #14

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Fix SH Runner False Negative #14

merged 2 commits into from
Aug 22, 2024

Conversation

AdnaneKhan
Copy link
Owner

Gato-X was not detecting a workflow as containing a potential self-hosted runner if it used a matrix job where the 'runs-on' value was a list of labels like so:

 build:
    strategy:
      matrix:
        profile: [ 'jdk17', 'jdk17-aarch64' ]
        include:
          - jdk_version: '17'
          - profile: 'jdk17'
            runs_on: ubuntu-latest
          - profile: 'jdk17-aarch64'
            runs_on: [ linux, ARM64 ]

This PR also moved the logic into the job step to clean up the bloat within the workflow parser file.

@AdnaneKhan AdnaneKhan merged commit 6d65651 into main Aug 22, 2024
12 checks passed
@AdnaneKhan AdnaneKhan deleted the runner_fp_fix branch August 22, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant