Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: New Script Format Not Supported #425

Closed
tseel opened this issue Aug 24, 2024 · 3 comments
Closed

Bug: New Script Format Not Supported #425

tseel opened this issue Aug 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tseel
Copy link

tseel commented Aug 24, 2024

Describe the bug
The script format has changed so that ids for characters with multiple words in their name no longer have an underscore. For example, the Fortune Teller used to be fortune_teller and is now fortuneteller.

These characters are not showing up properly in the character list.

To Reproduce
Is this problem reproduceable, if so, please provide the steps required to reproduce the behavior:

  1. Go to any recently created script which has characters with multiple words: for example Dogma by Luxray
  2. Go to the Characters tab
  3. See that in the character list, several characters have black text and their new IDs, instead of color based on character type and their character name.

Screenshots
image

@tseel tseel added the bug Something isn't working label Aug 24, 2024
@tseel
Copy link
Author

tseel commented Aug 24, 2024

Looks like this will be a database update, should support both IDs to not break old scripts.

Alternatively, could ignore underscores in IDs all together (this is what bra1n has said the official app does - have not confirmed myself lol)

@AdmiralGT
Copy link
Owner

Thanks for the report. I was completely unaware of this change. I know both formats have been valid for a while and I was mostly ignoring the problem as the format of the existing characters didn't change so it was only really an issue when people manually hacked them in some way (usually when a new character was released an not officially supported).

It's not possible to simply ignore underscores since all the existing JSONs are stored with the original IDs and so things like search won't just work without a mapping backwards to the originals (something has to know that if you search for scarletwoman or scarlet_woman actually means searching for scarletwoman and scarlet_woman.

That's what I originally proposed for the mephit issue but I ultimately cheapened out and just changed mephit to mezepheles everywhere. That's likely harder to do now as there are so many more scripts to search through and update but there's really not a great format for storing "this character can be one of n IDs". Likely may just have to be some downtime while I hammer the update.

It'll probably be a few days until this gets resolved. It's not really causing any harm from a functionality perspective beyond search by character and just cause general ugliness.

@AdmiralGT AdmiralGT pinned this issue Aug 30, 2024
@AdmiralGT
Copy link
Owner

I have migrated the database to remove special characters and now character usage everywhere is without special characters.

@AdmiralGT AdmiralGT unpinned this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants